Fix: #54 Specify a resource bundle encoding in @FXMLView-annotation

roskenet / springboot-javafx-support

SpringBoot / JavaFX8 Integration

MIT License

422 stars 139 forks source link

Fix: #54 Specify a resource bundle encoding in @FXMLView-annotation #55

Closed Pyknic closed 6 years ago

Pyknic commented 6 years ago

This PR adds the optional parameter encoding to the @FXMLView-annotation so that the encoding of the resource bundle can be specified. I also bumped up the version of the project to 2.1.6-SNAPSHOT since I am not sure what the convention for development versions is in this project.

coveralls commented 6 years ago

Coverage increased (+0.8%) to 54.73% when pulling 2e2ac0b3210ec7f1bf7bf55a1e68a470c5051fbe on Pyknic:master into eae93a744541d2b9bff2e5d9bf9d48201624aff2 on roskenet:master.

Pyknic commented 6 years ago

I also added a fix for #57 where the synchronized-block was removed and a CompletableFuture is used instead.