search

rospdf / pdf-php

Official R&OS PHP Pdf repository
http://pdf-php.sourceforge.net/
Other
136 stars 64 forks source link

Adjust full - last line #152

Open twoSGmbH opened 3 years ago

twoSGmbH commented 3 years ago

Hello,

with the commit 00db904dcb7f3c5af394b06e89674555e421e56a you deleted the calculation of the text option "full" for the last line. We think, its a better moving with the deleted calculation. Only adjust full, when 90 percent of the width is used. This is, why we say its a bug. Can you say, why do you deleted this?

Thank you for the reply.

Best regards

ole1986 commented 3 years ago

To be honest I could not remember. I was expecting to behave the same as "common text writers" but with my last finding that could be wrong.

So, I think that should than be configurable at least but also get a default value. I will try to investigate some time for this topic

ole1986 commented 3 years ago

Oh, I remember its justified similar to what CSS styles text-align: justify does.

twoSGmbH commented 3 years ago

Hi,

I think the CSS style text-align: justify is the best option. Its only stretch the line if the current line not the last. This is better than the 80 % calculation. It's the same process as word it have.

Can you integrate this solution? (Without the 80 % calculation)

ole1986 commented 3 years ago

to be honest I do not know when I have the chance to focus on this project. But feel free to add a PR. I can quickly review and we are good to go

kevinsdb commented 2 years ago

@ole1986 Hope you had a good Christmas! Have you had time to look into this issue? Best, Kevin

ole1986 commented 2 years ago

@kevinsdb unfortunately I did not had the chance yet to get into this