lsolesen
commented
8 years ago We need to discuss whether we are going fully PSR2 compliant for the repository. I think we should. We have the following rules turned off at the moment (https://github.com/ole1986/pdf-php/blob/experimental/phpcs.xml):
- PSR1.Classes.ClassDeclaration.MissingNamespace. I think we should use namespacing. Most other libraries are doing this at the moment.
- PSR1.Methods.CamelCapsMethodName.NotCamelCaps. I think we should follow this also and make the methodnames camelCaps.
- PSR1.Files.SideEffects.FoundWithSymbol. I also think we should not have side effects in the files, like including other files.
- PSR1.Classes.ClassDeclaration.MultipleClasses. I think we should go for one class per file.
- Squiz.Classes.ValidClassName.NotCamelCaps. Class names should be CamelCaps. We could shorten most class names by introducing the namespace and rely on use.
After thinking more about it, these are important to be addressed before merging experimental into master
I think the library should follow PSR2 coding standards. I've added tests to reflect the current coding standards based of PSR2 standards - and added automatic tests in TravisCI to see whether we adhere to them.
The coding standards are defined in
phpcs.xmland right now there is a little work to do. I will happily do it. However, I think we should merge inexperimentalintomasterfirst, if you think it is pretty much ready.