search

rospogrigio / daikin_residential

Cloud control of Daikin devices that are supported by Daikin Residential Controller app.
GNU General Public License v3.0
283 stars 37 forks source link

Breaking change in HA cause integration to fail #140

Closed ridderr closed 1 year ago

ridderr commented 1 year ago

Last update on HA (2023.6.0b0) causes integration to fail. `Deze fout is ontstaan door een aangepaste integratie.

Logger: homeassistant.config_entries Source: custom_components/daikin_residential/daikin_api.py:54 Integration: Daikin Residential Controller (documentation, issues) First occurred: 07:41:34 (3 occurrences) Last logged: 07:46:17

Error setting up entry Daikin for daikin_residential Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup result = await component.async_setup_entry(hass, self) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/config/custom_components/daikin_residential/init.py", line 84, in async_setup_entry daikin_api = DaikinApi(hass, entry) ^^^^^^^^^^^^^^^^^^^^^^ File "/config/custom_components/daikin_residential/daikin_api.py", line 54, in init self.openIdClient = Client(client_id=self.openIdClientId, config=configuration) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/oic/oic/init.py", line 354, in init self.settings = settings or OicClientSettings() ^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/oic/utils/settings.py", line 96, in init super().init( File "/usr/local/lib/python3.11/site-packages/oic/utils/settings.py", line 51, in init self.client_cert = client_cert ^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/oic/utils/settings.py", line 73, in setattr raise SettingsException( oic.utils.settings.SettingsException: client_cert has a type of <class 'NoneType'>, expected any of (<class 'str'>, <class 'tuple'>). `

jwillemsen commented 1 year ago

2033.6 seems to upgrade python, see https://rc.home-assistant.io/blog/2023/05/31/release-20236/#python-311-and-major-performance-upgrades, maybe that is related

jwillemsen commented 1 year ago

See https://github.com/CZ-NIC/pyoidc/issues/839 and https://github.com/CZ-NIC/pyoidc/issues/827

jwillemsen commented 1 year ago

Can you try to edit locally custom_components/daikin_residential/manifest.json and change 1.4.0 to 1.6.0 for oic

ridderr commented 1 year ago

Changed that and also installed another update of Home Assistant to 2023.6.0b1. The integration is working again. Not sure if this is because of above change or upgrade of HA. Many Thanks.

jwillemsen commented 1 year ago

Thanks for testing, made a pull request for the required change

jwillemsen commented 1 year ago

@rospogrigio or @ridderr Can you close this issue?

rospogrigio commented 1 year ago

Fixed by PR #141 , released within v2.3.1.

Marc1979 commented 1 year ago

Thanks for the quick fix (and sorry for opening a new issue)!