search

ross / requests-futures

Asynchronous Python HTTP Requests for Humans using Futures
Other
2.11k stars 152 forks source link

Configure the generation of a universal wheel. #102

Closed dbaxa closed 3 years ago

dbaxa commented 3 years ago

@ross you will also want to adjust your means of publishing to pypi to include generating and uploading a wheel.

dbaxa commented 3 years ago

to building a wheel.

@ross you will also want to adjust your means of publishing to pypi to include generating and uploading a wheel.

The current process is in https://github.com/octodns/octodns/blob/97dbb6a7828c70d20b12da6055cdb1700f2a4581/script/release. What would need to be adjusted in that. Probably makes sense to include those changes as part of the PR.

I take it that you are suggesting opening a pr to update the release file found in the octodns repository & not in this repository?

ross commented 3 years ago

@ross you will also want to adjust your means of publishing to pypi to include generating and uploading a wheel.

I found bdist_wheel which I assume is the bit that's needed to build the wheel. That resulted in:

$ python setup.py sdist sdist_wheel
...
(env) salmon:requests-futures ross$ ll dist/
total 40
-rw-r--r--  1 ross  staff  10736 Jan 12 17:49 requests-futures-1.0.0.tar.gz
-rw-r--r--  1 ross  staff   7434 Jan 12 17:49 requests_futures-1.0.0-py2.py3-none-any.whl

Beyond that is it just a matter of twine upload <both-those-files> to make both of them available on pypi or do I need to just upload the wheel from now on? Haven't looked at python packaging stuff in any detail for a long long time and don't have the bandwidth to dig into it atm.

dbaxa commented 3 years ago

What I typically do is run python setup.py sdist bdist_wheel & then twine upload dist/package-name-* (note: https://packaging.python.org/tutorials/packaging-projects/ suggests twine upload dist/*).