ross / requests-futures

Asynchronous Python HTTP Requests for Humans using Futures
Other
2.11k stars 152 forks source link

Feature: support ProcessPoolExecutor (Python >= 3.3 required) #31

Closed asfaltboy closed 8 years ago

asfaltboy commented 8 years ago

Change Summary

This relatively simple implementation fixes issue #11, however due to numerous caveats, I'd suggest we recommend it be used in Python 3.5 and above and explain the limitation of earlier versions. If earlier versions (like Python 2) are really required by someone they may need to implement a manual fix to the pickle implementation (e.g using copy_reg).

Personally, this PR solves my issue but I have yet to test it on production, hopefully, will do so in the near future.

ross commented 8 years ago

Sorry for the slow response. Super busy at work as of late. Looks pretty good. Few small comments inline.

asfaltboy commented 8 years ago

No problemo. I added an exception, some documentation and updated tests. Unfortunately, the README.rst does not render so well in GitHub, so feel free to style the doc to your liking.

ross commented 8 years ago

Thanks.