search

ross / requests-futures

Asynchronous Python HTTP Requests for Humans using Futures
Other
2.11k stars 152 forks source link

Factually incorrect call to Sessions#__init__ #41

Closed jon-torodash closed 2 years ago

jon-torodash commented 7 years ago

https://github.com/ross/requests-futures/blob/master/requests_futures/sessions.py#L54

suggests that requests.Session#init takes **kwargs, but this does not seem to be the case in the latest or any other recent versions:

https://github.com/kennethreitz/requests/blob/v2.12.4/requests/sessions.py#L308

Attempting to use them throws an exception.

ross commented 7 years ago

That's actually done so to be future proof. If/when args/kwargs are added to Session.__init__ you'd be able to use them with requests-futures. The error message/failure should be pretty much the same thing you get if you were to try and pass params to Session() so it shouldn't hurt anything to have them there.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.