Edit account not saving the name or email for clients

[jamieconnolly]

Inside EnsureCustomerService, we weren't actually saving the User. What I've done is replicate the the structure from the EnsureLawyerService class, and it now flows through and saves it.

I've removed the template cache fragment from templates/partials/nav.html, as (obviously) it won't update their details until the fragment has expired. I thought it would be better to remove it, as it doesn't seem to be beneficial to have this cached yet, over building in a way to expire the fragment when the form has been saved.

[rosscdh]

@jamieconnolly just one thing to modify here mate. then we can merge and move on

[jamieconnolly]

@rosscdh — Done. I've added in that check to lawyer/services.py too

[rosscdh]

@jamieconnolly good work mate.. thanks

[rosscdh]

@jamieconnolly ah! I jsut noticed your using User.objects.filter there are two things here

1. we already have the user object. self.user so you could call self.user.update()
2. if you want just 1 element in the ORM you can go User.objects.get(pk=:pk) or the first you can go User.objects.filter().first()
3. Id prefer you just reuse the user object?

[jamieconnolly]

@rosscdh — Done. I needed to rework the fields_to_update dict so it plays nicely. Again I've put the changes into the lawyer/services.py so we get some consistency.

[jamieconnolly]

@rosscdh — Done. What do you think?

[rosscdh]

@jamieconnolly 2 comments but other than that its looking good.

[jamieconnolly]

@rosscdh — Both of the changes have been done

[rosscdh]

hm tests are not green.. investigating.. ah its rate limiting by crocdoc.. man im going to have to get these socket connections being mocked.

[jamieconnolly]

Ok. Let me know what you find and I'll fix it