rosscdh / revision

video revision system
1 stars 0 forks source link

Use a custom user model instead of user profile #4

Closed miped closed 10 years ago

miped commented 10 years ago

I'm thinking this is the new and fancy way to do it (since like 1.5 or 1.6 or whatev.).. Anyway, might simplify some stuff a bit in the "me" app.

rosscdh commented 10 years ago

We have no need for a custom user model not by a long shot. Django provides us with all of the functionality that we need.

I've simply optimised the profile model and have a lamba to ensure the profile gets created of first ref.

Never been a fan of the need for the "custom user" aside from email as username djangos offering is pretty much there? unless u know of a counter argument?

miped commented 10 years ago

But we're adding a "data" property. Wouldn't it be better to just have a custom user model with all the default django stuff as well as this data field instead of a separate profile containing it?

rosscdh commented 10 years ago

its a question of what is better. easier to look at maybe. at scale you def dont want everythign in 1 table.. due to index updating on various fields.

ie. the index gets flushed on update of the user model (last modified etc).. if you have it all in 1 table and there are say 1000 users it will create problems.

There are certain problems when addressed earlier you never experience and thats the experience i prefer rather than massive database changes under load