rossengeorgiev / aprs-python

📡 Python module for working with APRS
http://aprs-python.readthedocs.io/en/latest/
GNU General Public License v2.0
118 stars 37 forks source link

Parsing Message Acks #23

Closed ghost closed 7 years ago

ghost commented 7 years ago

Using python3 and aprslib 6.45

Moving my server app to Aprs-Python from libfap-python to make it Python3 compatible. I deal exclusively with APRS messages.

The challenge I have is when an 'ack' message is rec'd from a client. It is parsing it as a 'message' with 'message_text'. I believe it should be a 'message' with 'response'. I have looked through old commits and issues with no indications of related issues.

Here is a parsed packet showing my challenge; {'via': 'T2SOCAL', 'format': 'message', 'to': 'APWW10', 'raw': 'KG7AFQ-11>APWW10,TCPIP,qAC,T2SOCAL::BAKERSMS :ack38648', 'from': 'KG7AFQ-11', 'message_text': 'ack38648', 'path': ['TCPIP', 'qAC', 'T2SOCAL'], 'addresse': 'BAKERSMS'}

I use APRSDroid, YAAC and APRSIS32 to test my application.

Thanks for your time

rossengeorgiev commented 7 years ago

Hi, I have no idea how libfap-python works. This package has not attempted to mimic the FAP library, so functionality can be different and not available. It simply parses APRS into a pythonic data format and has no notion of whether the message was send or received.

ghost commented 7 years ago

My apologies for not explaining my challenge better. It only involves APRS-Python.

This is a parsed aprslib packet. {'via': 'T2SOCAL', 'format': 'message', 'to': 'APWW10', 'raw': 'KG7AFQ-11>APWW10,TCPIP,qAC,T2SOCAL::BAKERSMS :ack38648', 'from': 'KG7AFQ-11', 'message_text': 'ack38648', 'path': ['TCPIP', 'qAC', 'T2SOCAL'], 'addresse': 'BAKERSMS'}

Based on the raw element, should it not show a response and msgno and not show message_text because it is an ack message.

Thanks, Brian

From: Rossen Georgiev [mailto:notifications@github.com] Sent: Saturday, January 28, 2017 10:50 AM To: rossengeorgiev/aprs-python Cc: bgmarble; Author Subject: Re: [rossengeorgiev/aprs-python] Parsing Message Acks (#23)

Hi, I have no idea how libfap-python works. This package has not attempted to mimic the FAP library, so functionality can be different and not available. It simply parses APRS into a pythonic data format and has no notion of whether the message was send or received. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rossengeorgiev/aprs-python/issues/23#issuecomment-275862883 , or mute the thread https://github.com/notifications/unsubscribe-auth/AB8o0QwBBIlb9vDNF9TbNJzmvQ-RS1Oyks5rW3-vgaJpZM4LwjQS . https://github.com/notifications/beacon/AB8o0X6id8BEXJ6DalCTH_DQW-hZ6q8Aks5rW3-vgaJpZM4LwjQS.gif

rossengeorgiev commented 7 years ago

Ok, I got what you mean. I've fixed the code, and released a new version on pypi