Closed stef closed 2 years ago
aprslib should remove py 2.7 tests as python 2 is dead.
Please consider pulling in wsmitchell3 PR# 48 to properly parse PHG message. Current regex in parse_data_extensions for PHG match = re.findall(r"^(PHG(\d[\x30-\x7e]\d\d[0-9A-Z]?))", body)
will consume the first char of the comment field if present. Possible fix would be match = re.findall(r"^(PHG(\d[\x30-\x7e]\d\d?))", body)
i believe. thanks.
From #62 I've updated the feedback. The PHG is supposed to be 4 decimals and the 1.2 spec allows for extension into PHGR of 5 decimals but is terminated by a "/" as to maintain backwards compatibility. So no "/" means only grab four decimals from the string and the rest is freeform data including comments, etc. Presence of a "/" at position 6 after PHG indicates PHGR and should be parsed differently.
This PR is too busy. I'm going to close it favor of individual PR for fixes and enhancements.
i cherry picked and tested some of the branches.i run this in production.