Open bensheldon opened 11 years ago
bensheldon
commented
11 years ago Also, I should comment that I appreciate you using Github Issues for tracking outstanding features/bugs rather than littering the code with 'todos'. Project management: you're doing it right.
rossettistone
commented
11 years ago Thanks so much for your time and feedback, Ben! This information is super-valuable for me, and every point makes sense. I'll address these with commits in the next day, and let you know if I have any questions.
Hi Mark, @shawndrost asked me to take a look at your project and give you some feedback. Summary: it looks pretty damn good, at least compared to my limited experience and exposure to Meteor.js projects.
A few things I did notice:
clients/lib. The convention for 3rd party libraries is to put them in a/vendorfolder (rather thanlibwhich is conventionally for your own DRY helper clases). Also, if it's available, you should link the non-minimized javascript for ease of debugging (assuming that it gets minimized as part of the meteor pipeline).client/opentok/opentok-setup.js. I'm not sure how particularly sensitive these are in regards to the OpenTok protocol, but I would recommend pulling them out into a root level/configdirectory to make them more discoverable if someone is setting their own.Otherwise, your coding style looks very clean, conventional and idiomatic. I had no difficulty understanding your code and its intended functionality. You didn't use very many comments (actually, I don't think I saw any, but perhaps I missed some), but your clear variable and function names and use of functional operators made them pretty unnecessary. So that's awesome.
Let me know if you have any questions or you have a module you want me to look more closely at.