rosshamish / kuskus

The extension pack so nice they named it twice
https://marketplace.visualstudio.com/items?itemName=rosshamish.kuskus-extensions-pack
45 stars 11 forks source link

authentication trouble #26

Closed stevenhurwitt closed 4 years ago

stevenhurwitt commented 4 years ago

i always have trouble authenticating with data explorer (web ui works, but kusto explorer does not), so it's def not specific to kuskus but is there any other way to authenticate? or maybe to choose a specific tenant id?

also i know nothing about vscode extensions or typescript but just wanted to say thanks for this! was disappointed there's no kusto extension in VS so this is nice. i'd like to learn enough to make an extension for kusto similar to mssql in VSCode or npgsql in VS, but who know...

stevenhurwitt commented 4 years ago

Please see this pull request regarding my changes: https://github.com/rosshamish/kuskus/pull/27. If anyone happens to be reading this who also get auth errors with the "common" authority id feel free to use my fork that enables an authority/tenant id parameter.

rosshamish commented 4 years ago

I'd like to learn enough to make an extension for kusto similar to mssql in VSCode or npgsql in VS, but who know...

Hey I mean, if you're interested in learning you're welcome to build an extension and once it reaches some level of stability we could bundle it into this extension pack. I won't be able to spend much time actively developing on this but I can definitely be around for discussion and reviews and such.

Please see this pull request regarding my changes: #27.

Reviewed and approved. Looks good! Thanks for the change!