search

rossimo / retrobot

MIT License
281 stars 16 forks source link

Removed .env from .dockerignore #16

Closed sedand closed 1 year ago

sedand commented 1 year ago

Otherwise the discord token wouldn't be available inside the docker image.

rossimo commented 1 year ago

Thanks @sedand !

rossimo commented 1 year ago

Hey, sorry, I'm going to have to revert this. As a security concern, the credentials shouldn't be packed into the image. Docker does have other ways of providing environment variables to containers, though: https://docs.docker.com/compose/env-file/. Seems close.

As a note, Docker recomendation on "secrets": https://docs.docker.com/engine/swarm/secrets/.