search

rossjrw / pr-preview-action

GitHub Action that deploys a pull request preview to GitHub Pages, similar to Vercel and Netlify, and cleans up after itself.
https://github.com/marketplace/actions/deploy-pr-preview
MIT License
267 stars 43 forks source link

Allow transient action versions to be specified #10

Closed airtonix closed 2 years ago

airtonix commented 2 years ago

https://github.com/JamesIves/github-pages-deploy-action/issues/1103

rossjrw commented 2 years ago

I don't know what you mean by this - could you please add a more detailed description?

rossjrw commented 2 years ago

@airtonix I'm going to close this issue as it's not clear what you want. Feel free to reopen it with a more detailed description.

airtonix commented 2 years ago

@rossjrw needs to be reopened.

i didnt get notified.

bascially you hard code the version of your transient actions. those versions are broken.

if you make the version an input we can specify a version we want without continually requiring you to update the repo

airtonix commented 2 years ago

it's a shame, really. i wanted to use this, but nothing worked so yeah... looks like I'll have to fork it and publish my own version with fixes

rossjrw commented 2 years ago

Did you want to be able to specify a version of e.g. JamesIves/github-pages-deploy-action?

Please do fork and make a pull request - I'll be happy to accept a contribution.