search

rossjrw / pr-preview-action

GitHub Action that deploys a pull request preview to GitHub Pages, similar to Vercel and Netlify, and cleans up after itself.
https://github.com/marketplace/actions/deploy-pr-preview
MIT License
255 stars 39 forks source link

fix: rename event_type to event_name #30

Closed okinawaa closed 1 year ago

okinawaa commented 1 year ago

Thank you very much for providing a good library. I tried it and it's really good.

One thing I found inconvenient while checking the log.

image

I was confused because I specified other variables as event_type together.

Thank you again!

rossjrw commented 1 year ago

You're right! I imagine I was thinking of https://docs.github.com/en/developers/webhooks-and-events/events/github-event-types when I wrote this, but as you say, it's inaccurate - the 'event type' would always be PullRequestEvent. Thanks for the contribution!