search

rossjrw / pr-preview-action

GitHub Action that deploys a pull request preview to GitHub Pages, similar to Vercel and Netlify, and cleans up after itself.
https://github.com/marketplace/actions/deploy-pr-preview
MIT License
275 stars 44 forks source link

Deprecate set-output #35

Closed noatamir closed 1 year ago

noatamir commented 1 year ago

I noticed deprecation warning on set-out and followed the documentaiton here: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I'm not sure experienced in solving such issues, so I wasn't sure how to test it, and suggestions on how to proceed would be welcome.

rossjrw commented 1 year ago

Thank you! Will make sure I take a look at this sometime before May 2023 :P

oraNod commented 1 year ago

@rossjrw Hello. I also noticed the same warning about the deprecated command in a recent PR.

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

FWIW, based on the details in that blog post I think the changes in this PR should be alright. Could you please take a look before the commands are disabled at the end of the month? Thanks.

rossjrw commented 1 year ago

Looks good. Thank you @noatamir! (and thank you @CMDJojo 😛)

Released in v1.4.2