search

rossjrw / pr-preview-action

GitHub Action that deploys a pull request preview to GitHub Pages, similar to Vercel and Netlify, and cleans up after itself.
https://github.com/marketplace/actions/deploy-pr-preview
MIT License
267 stars 43 forks source link

Rename parameters to be consistent with JamesIves' action #4

Open rossjrw opened 2 years ago

rossjrw commented 2 years ago

It was a silly idea to make this action so parallel to JamesIves', while also renaming parameters.

E.g. 'source-dir' should be renamed to 'folder'.

This will result in much easier integration with projects using JamesIves/github-pages-deploy-action, which is the intended use case.

I should retain the current parameters, but mark them as deprecated.

rossjrw commented 2 years ago

I'm going to be releasing v2 sometime after merging #6, so I may as well get this out of the way then. Best to lump all the breaking changes together.

airtonix commented 2 years ago

can you also please expose all the variables from JamesIves/github-pages-deploy-action ...

any that you don't use directly, just pass them through to it.