rossjrw / pr-preview-action

GitHub Action that deploys a pull request preview to GitHub Pages, similar to Vercel and Netlify, and cleans up after itself.
https://github.com/marketplace/actions/deploy-pr-preview
MIT License
267 stars 43 forks source link

Fix 404 page on storybook preview instances #5

Closed jleifeld closed 2 years ago

jleifeld commented 2 years ago

The generated URL does not work in every scenario.

In my case I want to create a preview of storybook. The generated URL does not work directly and redirects to a 404 page. If I add a slash manually at the end of the URL then it works.

This fix is relatively simple and just adds a slash at the end of the preview link. This should also does not break existing links.

rossjrw commented 2 years ago

Nice find, thank you!