Comment shows target repo version, not action version

rossjrw / pr-preview-action

GitHub Action that deploys a pull request preview to GitHub Pages, similar to Vercel and Netlify, and cleans up after itself.

https://github.com/marketplace/actions/deploy-pr-preview

MIT License

287 stars 46 forks source link

Comment shows target repo version, not action version #51

Closed gzaripov closed 1 year ago

gzaripov commented 1 year ago

We have a lot of different tags in our repo using it in documentation preview title is kind of silly. Please add feature to change or remove it, it would make our PR comment much nicer!

Example of how it looks right now:

rossjrw commented 1 year ago

Oh no! That's not supposed to happen. That's supposed to show the current version of PR Preview Action, not the version of the repository being previewed. Sort of nuts that I missed this. Thanks for raising!

gzaripov commented 1 year ago

Here are logs with details

gzaripov commented 1 year ago

The same thing when I set the latest version of action explicitly

rossjrw commented 1 year ago

Thanks @gzaripov. Fixed in v1.4.3

gzaripov commented 1 year ago

I confirm that fix works! Thank you so much for a quick fix!