search

rosskukulinski / kubernetes-rethinkdb-cluster

RethinkDB cluster on top of Kubernetes made easy.
MIT License
139 stars 40 forks source link

Proper Health Check #11

Closed rosskukulinski closed 7 years ago

rosskukulinski commented 8 years ago

Should have simple Go binary in the container that connects to Rethink and confirms that db is healthy.

paralin commented 8 years ago

Done in #18, sort of. I just curl localhost:8080. But you're right, a better go binary to do it is in order.

justinsb commented 8 years ago

What should a more comprehensive health check do? Willing to write one, but would love to know what we think would be the appropriate checks..

rosskukulinski commented 8 years ago

Hi @justinsb! I was thinking a simple binary that accessed the rethinkdb instance and queried one or more system tables to verify functionality.

As to which system tables, I haven't fully thought that through. I don't think we want to report readiness/health check based on the overall cluster availability - we might just be making things worse.

So, then I guess the instance is 'ready' when you can query server_status and there's one or more records.

tjmehta commented 8 years ago

I would also be willing to write this. Please let us know if you have any more details on this.

rosskukulinski commented 7 years ago

first pass of probe complete - thanks @cdornsife