search

rosslavery / angular2-tag-input

Tag input component for Angular 2
45 stars 42 forks source link

Made your cool plugin angular-rc.1-ready #2

Closed mark-langer closed 8 years ago

mark-langer commented 8 years ago
rosslavery commented 8 years ago

This looks great, thanks a lot for the help!

mark-langer commented 8 years ago

I am glad I could help! Am 02.06.2016 14:45 schrieb "Ross Lavery" notifications@github.com:

Merged #2 https://github.com/rosslavery/angular2-tag-input/pull/2.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rosslavery/angular2-tag-input/pull/2#event-679744176, or mute the thread https://github.com/notifications/unsubscribe/ARTTohRlLGECLTMDcwEg6sMmxQuFq3nJks5qHtBugaJpZM4IsA05 .

rosslavery commented 8 years ago

I actually found a small bug that's turning into a bit of a pain to fix. Now that the delimiters accepts an array, pasting and splitting is no longer working.

Working on it now. Just FYI that's why I haven't re-published to npm yet.

mark-langer commented 8 years ago

Thanks for the info. I'll have a look at the solution you come up with later on.

Thanks by the way for the plugin overall. You implemented some pretty good ideas.

Last night I thought about using regex to match against the input value and find strings to be turned into tags. Then one could use something like "#myTag" too, with a special char at the beginning of the word. I didn't build it though since it would pose a major change to your code. What do you think about it though? Am 02.06.2016 16:07 schrieb "Ross Lavery" notifications@github.com:

I actually found a small bug that's turning into a bit of a pain to fix. Now that the delimiters accepts an array, pasting and splitting is no longer working.

Working on it now. Just FYI that's why I haven't re-published to npm yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rosslavery/angular2-tag-input/pull/2#issuecomment-223302587, or mute the thread https://github.com/notifications/unsubscribe/ARTTooKgFV2xU8YAse8U6DFPh9Yf7TtBks5qHuO4gaJpZM4IsA05 .