Conditional sourcing of plugins using profiles

rossmacarthur / sheldon

:bowtie: Fast, configurable, shell plugin manager

https://sheldon.cli.rs

Apache License 2.0

1.02k stars 21 forks source link

Closed mkroli closed 2 years ago

mkroli commented 2 years ago

This contributes to #119 although it uses a different approach.

mkroli commented 2 years ago

Thanks for the detailed review. Can you please check my recent changes?

mkroli commented 2 years ago

Thanks once more! Worked on your suggestions.

rossmacarthur commented 2 years ago

Hmmm build is failing I think my suggestions were not 100% correct code.

mkroli commented 2 years ago

Didn't catch the compilation errors. Latest commit reverts some code but removes the unnecessary collect you mentioned.