search

rossmacarthur / sheldon

:bowtie: Fast, configurable, shell plugin manager
https://sheldon.cli.rs
Apache License 2.0
958 stars 21 forks source link

Use fs2 instead of fmutex for cross-platform mutex support #170

Closed kvnxiao closed 6 months ago

kvnxiao commented 6 months ago

For resolving https://github.com/rossmacarthur/sheldon/issues/167

Excerpt for error message from failing to perform File.read:

sheldon source

error: failed to open `C:\Users\kvnxiao\.config\sheldon`: The system cannot find the file specified. (os error 2)
kvnxiao commented 6 months ago

This is a work in progress, @rossmacarthur let me know what we should do for the failing test case

kvnxiao commented 6 months ago

@rossmacarthur going to have to leave this draft open for a while. I encountered issues aside from the filesystem mutex on Windows, with regards to cloning repositories. Half the time repos won't clone properly when running sheldon lock etc.

rossmacarthur commented 6 months ago

@kvnxiao could you elaborate on the issues you encountered in case someone else wants to tackle this in the future?

ghost commented 6 months ago

Honestly not sure what the exact issue was since I don't have the time to investigate deeply but I summarized in my previous comment how the git clone steps fails for random plugins as well as tests