search

rossmann-engineering / EEIP.NET

Ethernet/IP compatible library for .NET implementations
MIT License
210 stars 120 forks source link

Added missing references to EEIP project. #11

Closed rtigithub closed 4 years ago

rtigithub commented 4 years ago

Added missing references to EEIP project. Specified build dependencies.

I am using VS2019 so the changes to the .sln file should not be automatically merged.

ngbrown commented 4 years ago

This patch doesn't add the <ProjectReference/> tag to each project that is really needed.

Please see https://github.com/ngbrown/EEIP.NET/commit/dae7956594534862057712e7a4a0b531c7d97e24 for a more complete solution.

rtigithub commented 4 years ago

Thank you for reviewing. From what I can tell the correct reference already exists in most of the projects in the current rossmann-engineering:master branch, except for the two in this pull request.

ngbrown commented 4 years ago

@rtigithub Referencing the main library project with a normal <Reference /> is not enough.

7 of the sample projects are missing the <ProjectReference />. This matters because while a normal <Reference /> will seem to find the dependency and compile, it won't necessarily build in the correct order.

Without the <ProjectReference />, it won't re-build the sample project, or copy in the updated library, if only the EEIP library project has changed.

rtigithub commented 4 years ago

@ngbrown Thank you. This really helps. I will merge your code into our fork. So the <Reference /> tag should be removed, and replaced with the correct <ProjectReference />?

Is Ross-Engineering still maintaining this repository, and responding to pull requests? Or is your fork considered the more active?

TheColonel2688 commented 4 years ago

It doesn't look like @rossmann-engineering maintains this anymore. We may want to look at picking someone's fork, and continuing to maintain this our selves. Or create a new github organization and for it to that. Then maintain it from there.

@ngbrown thoughts?

rossmann-engineering commented 4 years ago

The project is still active and maintained, of course sometimes more sometimes less depending on the time I am able to spend.

ngbrown commented 4 years ago

@rtigithub it looks like you didn't update the branch for this pull request with the <ProjectReference /> changes, and now it is merged.

TheColonel2688 commented 4 years ago

ugh

rtigithub commented 4 years ago

@ngbrown Since rossmann-engineering is still being maintained, will you issue a pull request with your recommended updates?