search

rossmann-engineering / EasyModbusTCP.NET

Modbus TCP, Modbus UDP and Modbus RTU client/server library for .NET implementations
928 stars 402 forks source link

Re-write serial handler #21

Closed mcurry-va closed 5 years ago

mcurry-va commented 5 years ago

The current serial handling is appalling, relying on timeouts, thread sleeps and other general 'bad code smell' issues.

rossmann-engineering commented 5 years ago

So you are complaining about the code, but were exactly is the issue?

mcurry-va commented 5 years ago

Issue #5 looks to be a direct relation to the issues I've mentioned.

The fix used there (synchronous calls) bypasses this code.