Closed mnapoli closed 10 years ago
Hey. This is purely due to protected keywords. See: https://github.com/rossriley/php-scalar-objects/issues/1
Damn, I forgot about that. Would suffixing the names with something like ArrayHandler
, or ArrayClass
be a solution? At least it would be consistent, Arrays
really makes no sense because it can be interpreted as "array of array".
Yes, I agree. It's not crucial since when we make an RFC for this the classes will be implemented as native zend_class types just like the Spl... classes so I imagine we'll rename them something like ScalarStringHandler unless PHP core is going to implement namespaces for internal classes (which I doubt will happen).
However it'll be good to make the code sane in this project in the meantime, it will give us less hassle when we get it to RFC stage too.
Current class names:
This is inconsistent, some are singular, some plurals.
I suggest the following naming: