rossrowe / sauce-teamcity-plugin

Plugin for TeamCity which provides integration with Sauce Labs
Apache License 2.0
15 stars 5 forks source link

Selecting a resolution based on browser variant is not transparent #5

Open Tallisado opened 10 years ago

Tallisado commented 10 years ago

When using multiple browsers that all require a particular browser resolution higher than default, browsers which don't support the higher resolutions will fail only after being executed.

Valid values for Windows XP, Windows 7, and OSX 10.6 are: "800x600", "1024x768", "1280x1024", "1440x900" and "1920x1200".
Valid values for OSX 10.8 are: "1024x768", "1280x1024", "1400x900", and "1920x1200".
Valid values for Windows 8/8.1 are "1024x768" and "1280x1024"

Should the plugin also provide a value, json or otherwise, in SAUCE_ONDEMAND_BROWSERS or SELENIUM_DRIVER to indicate what highest supported resolution is available for that browser permutation? This way we can programmatically decide whether the resolution will be accepted, or if we need to supersede the value in the browser capability prior to execution.

Maybe later this should be a feature added in the sauce API itself, such as the 'Browser Capability' string. It now only takes a quite static value of which browser to 'try':

name:%s,platform:%s,version:%s,browserName:%s,javascriptEnabled:True,screen-resolution:1280x1024 

where, it could actually be more dynamic and accept

screen-resolution:max

or the like. This is obviously more complicated, as the resolution would have to be determined server side...

Thoughts??