search

rosstcarter / zane-grey_betty-zane

Other
0 stars 0 forks source link

[Editorial] commits didn't really need to be marked as such #5

Open drgrigg opened 2 years ago

drgrigg commented 2 years ago

You have a series of commits tagged as "[Editorial] Ch NN corrections" but from a few quick samples these are your fixes to the transcription from the page scans (well done for that careful work, by the way).

Because these are valid corrections to the transcription, I don't believe they needed to be marked as [Editorial], which is meant to indicate that we've made an editorial choice which others might want to reverse.

I don't suggest that you do anything about this (unless @acabal wants to weigh in) but just bear it in mind for future projects.

acabal commented 2 years ago

You should remove [editorial] from the message to prevent confusion in the future. This is very easy with an interactive rebase, just google how to edit old commit messages. If you're unfamiliar with git rebase, just make a copy of the repo somewhere else in case you screw something up, so you can just restore the backup and try again. Then you can force-push to github.

rosstcarter commented 2 years ago

Done

drgrigg commented 2 years ago

Ross, you're going to hate me, but you needed to leave the [Editorial] at the start of the Modernize hyphenation and spelling commit. [Editorial] marks changes we have made as an editorial decision, changes which differ from the original text as shown in the page scans. Corrections such as fixing typos, which change the text of a transcription to match the original page scans shouldn't have the [Editorial] tag.

rosstcarter commented 2 years ago

No problem at all! Now that I know how to use git rebase -i, it’s easy to change a commit message. Done.

I am not clear on exactly when to use [Editorial], despite your helpful explanation. I might start a discussion thread on this, or look for one among past threads.

On Dec 3, 2021, at 7:23 PM, David Grigg @.***> wrote:

Ross, you're going to hate me, but you needed to leave the [Editorial] at the start of the Modernize hyphenation and spelling commit. [Editorial] marks changes we have made as an editorial decision, changes which differ from the original text as shown in the page scans. Corrections such as fixing typos, which change the text of a transcription to match the original page scans shouldn't have the [Editorial] tag.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

drgrigg commented 2 years ago

I’ll have to get you to teach me about how to use rebase because it always terrifies me!

rosstcarter commented 2 years ago

Any time! I confess I practiced on a backup first.

On Dec 4, 2021, at 5:23 PM, David Grigg @.***> wrote:

I’ll have to get you to teach me about how to use rebase because it always terrifies me! — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.