search

rossvideo / Catena

Other
4 stars 0 forks source link

Constraint type looks wrong #114

Closed mejohnnaylor closed 3 months ago

mejohnnaylor commented 4 months ago 
message Constraint {
  enum ConstraintType {
    UNDEFINED = 0;
    INT_RANGE = 2;
    FLOAT_RANGE = 4;
    INT_CHOICE = 5;
    STRING_CHOICE = 40;
    STRING_STRING_CHOICE = 6;
    ALARM_TABLE = 7;
  }

why is STRING_CHOICE = 40? looks like a typo.

Note the UML documents the choices thus:

NULL = 0 INT_RANGE = 1 FLOAT_RANGE = 2 INT_CHOICE = 3 STRING_CHOICE = 4 STRING_STRING_CHOICE = 5 ALARM_TABLE = 6 STRUCT = 7

They need to match.

james-peltzer commented 4 months ago

They're all different from the OGP-Binary versions so I'm fine to update. 40 does seem odd. This is what DashBoard uses internally (inherited from the binary days) image