Closed mejohnnaylor closed 3 months ago
Not intentional. Was probably demoing vscode’s json-schema enabled auto-complete feature.
From: james-peltzer @.> Date: Wednesday, March 20, 2024 at 9:12 AM To: rossvideo/Catena @.> Cc: John Naylor @.>, Author @.> Subject: [EXTERNAL] Re: [rossvideo/Catena] update schemas to reflect constraint changes in proto (PR #129)
@james-peltzer commented on this pull request.
In example_device_models/device.one_of_everything.jsonhttps://github.com/rossvideo/Catena/pull/129#discussion_r1532055979:
@@ -1,7 +1,7 @@
{
"slot": 1,
"multi_set_enabled": true,
"detail_level": "FULL",
"detail_level": "COMMANDS",
What's with the change in detail level here?
— Reply to this email directly, view it on GitHubhttps://github.com/rossvideo/Catena/pull/129#pullrequestreview-1948842377, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6R5EELWFL2LSWHF6L6PHDTYZGDJ5AVCNFSM6AAAAABEW7IGD2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBYHA2DEMZXG4. You are receiving this because you authored the thread.Message ID: @.***>
This e-mail and any attachments may contain information that is confidential to Ross Video.
If you are not the intended recipient, please notify me immediately by replying to this message. Please also delete all copies. Thank you.
I made the change again. please approve so we can merge. At least merging is blocked until approval is there :-)
a bit of adjustment in the schema and example device models to catch up with the .proto definition for constraints.