Fixed kind checking setValue for arrays

No need – it’s syntactic sugar, but I prefer the assignment operator

From: johndanenRV @.> Date: Tuesday, May 28, 2024 at 8:47 AM To: rossvideo/Catena @.> Cc: John Naylor @.>, Review requested @.> Subject: [EXTERNAL] Re: [rossvideo/Catena] Fixed kind checking setValue for arrays (PR #172)

@johndanenRV commented on this pull request.

In sdks/cpp/common/src/ParamAccessor.cpphttps://github.com/rossvideo/Catena/pull/172#discussion_r1617279470:

@@ -514,7 +514,7 @@ void ParamAccessor::setValue(const std::string& peer, const Value &src, ParamInd

         setterAt[value.kind_case()](value, src, idx);

     } else {

         // update scalar value or whole array

value.CopyFrom(src);
value = src;

It does just call CopyFrom. I will change it back though just to make it a bit more clear.

— Reply to this email directly, view it on GitHubhttps://github.com/rossvideo/Catena/pull/172#discussion_r1617279470, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6R5EELBGQG3SQXE5FDR7QDZESDHPAVCNFSM6AAAAABILVTD4SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBSHA2DOMZUHE. You are receiving this because your review was requested.Message ID: @.***>

This e-mail and any attachments may contain information that is confidential to Ross Video.

If you are not the intended recipient, please notify me immediately by replying to this message. Please also delete all copies. Thank you.

rossvideo / Catena

Fixed kind checking setValue for arrays #172