Closed mejohnnaylor closed 6 months ago
That looks like a copilot hallucination. Iād never have made that comment š. Good catch!
Get Outlook for iOShttps://aka.ms/o0ukef
From: james-peltzer @.> Sent: Thursday, February 8, 2024 4:28:19 PM To: rossvideo/Catena @.> Cc: John Naylor @.>; Author @.> Subject: [EXTERNAL] Re: [rossvideo/Catena] added stateless flag to param (PR #75)
@james-peltzer commented on this pull request.
In interface/param.protohttps://github.com/rossvideo/Catena/pull/75#discussion_r1483610393:
@@ -165,6 +165,12 @@ message Param {
// When true, indicates that the parameter is part of the minimal set of parameters that should be reported by the device bool minimal_set = 18; +
stateless does not imply no slot. it simply implies that its value is not expected to be persisted.
ā Reply to this email directly, view it on GitHubhttps://github.com/rossvideo/Catena/pull/75#pullrequestreview-1871291288, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6R5EEPBRPEGRIM7M6ISS6LYSU7PHAVCNFSM6AAAAABC4TJJZ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZRGI4TCMRYHA. You are receiving this because you authored the thread.Message ID: @.***>
This e-mail and any attachments may contain information that is confidential to Ross Video.
If you are not the intended recipient, please notify me immediately by replying to this message. Please also delete all copies. Thank you.
adds a boolean called "stateless" to the Param proto message and updates the json schema to validate the param schema.