james-peltzer
commented
6 months ago Yes, there are some breaking changes for the Java SDK. If you're okay with it, I'll just commit directly to this branch prior to merge.
James Peltzer (He/Him) Technical Director - DashBoard & Ross Platform Manager T: +1 (613) 228-0688 x4295 Ross Video | Let's make it real Visit us at rossvideo.comhttps://www.rossvideo.com/ @.**@*.**@*.**@.https://go.rossvideo.com/l/1033383/2023-11-20/89j1 @.***
From: John R. Naylor @.> Sent: Thursday, February 8, 2024 9:23 AM To: rossvideo/Catena @.> Cc: James Peltzer @.>; Assign @.> Subject: [EXTERNAL] Re: [rossvideo/Catena] de-nested param's type: {type: ""} (PR #76)
You don't often get email from @.**@.>. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
@mejohnnaylor commented on this pull request.
In interface/param.protohttps://github.com/rossvideo/Catena/pull/76#discussion_r1483054201:
- /* oneof kind { Unless we make array a separate flag, we need to be able to specify both a ref and a type override
-
- ParamTypes param_type = 1;
-
*
-
- // Non-relative JSON pointer to a param elsewhere in the model.
-
- string param_ref = 2;
-
- }
-
*/
-
/* Defines the parameter type.
-
- Can be defined in-line
-
- or reference a shared type definition from device.types.params
-
*/
-
Type type = 1;
-
// Non-relative JSON pointer to a param elsewhere in the model.
-
string template_oid = 2;
}
message BasicParamInfo {
ok will do. Will this update break the java code? If so, perhaps you could do some work on this branch to fix that before we merge to develop?
- Reply to this email directly, view it on GitHubhttps://github.com/rossvideo/Catena/pull/76#discussion_r1483054201, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6QNOHMMOZDICSERUMI4GNLYSTNSXAVCNFSM6AAAAABC6U55OWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZQGM2TKMRYGM. You are receiving this because you were assigned.Message ID: @.**@.>>
This e-mail and any attachments may contain information that is confidential to Ross Video.
If you are not the intended recipient, please notify me immediately by replying to this message. Please also delete all copies. Thank you.
mejohnnaylor
github-advanced-security[bot]
changed param.proto to de-nest param's type-type as discussed. updated schemas as needed updated test device models to use new schema fixed how these changes broke the c++ sdk.