search

rosswf / typing-trainer

Typing trainer made in pygame
MIT License
5 stars 7 forks source link

Game settings with tkinter #8 #11

Closed issamoxix closed 3 years ago

issamoxix commented 3 years ago

Created the Settings window, and I added the keyboard layout options because since I have a different keyboard EU one I guess so I added the option so that people with different keyboard layouts can play

rosswf commented 3 years ago

Thanks for looking into this!

Just a few things:

1) What was the issue with the keyboard layout? I see that you use event.unicode if this is checked. Would doing that work with a qwerty keyboard, so that there doesn't need to be a toggle for it? Rather than using event.key. This is my first time working with pygame so if event.unicode is better then we can just use that everywhere?

2) Would it be possible for the previous settings to be saved, so that if the user plays again, they don't have to change the settings again?

3) Could a file dialog be added for browsing to the word list?

4) Could the labels of each setting be changed to look nice, also some of them are cut off. Maybe break it up into categories, so you could have like

Display Settings

Width: Height: Font Size:

Word Settings:

Falling speed: Words per minute: Minimum Word Length: Maximum Word Length: Number of Words:

etc.

issamoxix commented 3 years ago

I didn't change the design but now you can save the settings in the JSON file I'm not good with designs