Strange bugs that need fixin'

rossyndicate / nps_water_vulnerability

Workflow for the NPS climate change vulnerability assessment – security of park water supplies.

1 stars 3 forks source link

Strange bugs that need fixin' #38

Closed kathryn-willi closed 1 year ago

kathryn-willi commented 1 year ago

1) CODE PROBLEM. In src/getBuildings: line 14. "Error in CPL_get_z_range(obj, 3) : z error - expecting three columns;" I also have not figured out a nice way to download this using RSelenium or rvest, though NPS permissions might alleviate this issue. Caitlin, could you run this function for me to see if this is a me issue, or a function issue?

2) Fixed a couple bugs in the src/getNOAA and src/getWQPData - they should be working now across any park boundary.

3) Made "dist" = 0 for all functions as default.

ccmothes commented 1 year ago

I get the same error message. I haven't looked at this raw buildings shapefile but I think it might have a mix of xy and xyz columns which is causing the error when trying to read it in with st_read(). I found this issue: https://github.com/r-spatial/sf/issues/1592. The last post was last week and said the dev version of sf fixes this, although I tested it out and was having trouble installing the dev version so I was not able to see if its working now or not.