This PR addresses some of the concerns that we have had regarding the add_suspect_flag() and how it is working. Once this PR has been reviewed it can and should be closed without merging.
test_env/: This is the new folder that was created to test the add_suspect_flag() function.
generate_subset_data.R: This file generates the data to test add_suspect_flag() on existing data.
test-add_suspect_flag.R: This file tests add_suspect_flag() through a series of conditions.
How the function behaves when put on a single row.
How the function behaves on data frames with a combination of flags and patterns
Data frames with only flag strings that are ignored
0-100% flagged data in 25% increments
All combinations of the previous percentages of flagged data.
How the function behaves on data that is being used as the historically flagged data that is being appended
new-add_suspect_data.R: Updated function with simple fix.
test_data/: Directory that holds the data generated by generate_subset_data
I believe that this function is not working as expected. I cannot identify the portion of the function that excludes the flag itself "suspect data" from being excluded from the flagging count. I have included a file with the fix for the function.
This PR addresses some of the concerns that we have had regarding the add_suspect_flag() and how it is working. Once this PR has been reviewed it can and should be closed without merging.
test_env/: This is the new folder that was created to test theadd_suspect_flag()function.generate_subset_data.R: This file generates the data to testadd_suspect_flag()on existing data.test-add_suspect_flag.R: This file testsadd_suspect_flag()through a series of conditions.new-add_suspect_data.R: Updated function with simple fix.test_data/: Directory that holds the data generated bygenerate_subset_dataI believe that this function is not working as expected. I cannot identify the portion of the function that excludes the flag itself "suspect data" from being excluded from the flagging count. I have included a file with the fix for the function.