rossyndicate / poudre_sonde_network

MIT License
0 stars 7 forks source link

New {targets}-style mapping approach #104

Closed kathryn-willi closed 6 months ago

kathryn-willi commented 6 months ago

Hi Juan,

This PR looks big but it is almost exclusively editorial changes to our comments and some roeorg of some old documents.

The big changes are:

1) Fix to DT parsing in API_puller.R. I don't think it was working properly before. This seems to be a recurring issue for us - could you confirm this is working now? 2) Start to "biofilm" flag. This is still not in a great place. I plan to continue working on this for us, so don't worry about reviewing too deeply! 3) I added the sensor_malfunction.R flag to our workflow ((finally))! 4) I started adding some {targets} features we weren't using before! Namely, pattern which allows the workflow to skip over components of map if there is no new data to update within that component, and require to track function outcomes that don't return objects. I would like you to continue incorporating these new {targets} features across the entire workflow for us.

-Katie