rossyndicate / poudre_sonde_network

MIT License
0 stars 8 forks source link

New intrasensor functions and some half-baked reorg! #117

Closed kathryn-willi closed 6 months ago

kathryn-willi commented 6 months ago

Juan,

I started work on some "intrasensor" flagging functions, including a flag looking for times where temp <= 0, and the "biofouling" flag that compares the slope of turbidity in SpC to find drift.

I also moved the mWater code into the "download_and_flag_fxns". This is something I would like to talk to you about more in-depth, but I think we will need to move/straighten up this repo when we move it into FCW's system. I'm thinking we could move all functions into a single src/ folder, generated tables (like our seasonal thresholds, spec thresholds, etc.) into a thresh/ folder, and any API credentials into a creds/ folder.

Moreover, I started explicitly calling out packages on all functions. This is something I would like to include across the entire workflow to ensure it's calling the correct thing in FCW's system (basically just a precautionary step).

-Katie