rossyndicate / poudre_sonde_network

MIT License
0 stars 8 forks source link

Fixes addressing the FDOM issue #139

Closed kathryn-willi closed 4 months ago

kathryn-willi commented 4 months ago

Here's my current approach for solving the FDOM plotting issue. It seemed to occur within the add_threshold_lines() function when there are only NAs in a given week of data. So, I just skip that function in those instances. This is a bit of a stop-gap measure; I think the real issue lies in what the function tries to return when there is no data (i.e., I think one of the conditional statements/parentheses are not quite correct).

I also made a change to the summarize_site_parameter_full() function so that field notes are correctly added to Virridy sites (before this PR, they didn't have field notes).