rossyndicate / poudre_sonde_network

MIT License
0 stars 8 forks source link

Remove duplicate verification workflow, modified network_check, mod to shiny app #143

Closed kathryn-willi closed 3 months ago

kathryn-willi commented 3 months ago

Juan,

I've deleted the verification steps that exist in our qaqc_lower folder. This is because we will want to verify all the data, using all the data. Currently, all site-parameters now exist in the all_data_flagged_complete.RDS in the virridy folder (i.e., the upper sondes, the lower sondes, and the virridy sondes co-located with the lower sondes). We should rename our "virridy" folders, workflows, etc. to "all_sondes" or something along those lines since it now includes more than just the virridy data. (I'm holding off until the workflow is more stable.)

@SamStruthers this PR additionally includes updates to the shiny app, so that you can log transform the data now.

I've also included a modification to the network check function, which lists the network order appropriately now. It still doesn't have the comparison of co-located data in it, but thought I'd share it with you anyways!

The last change is that I've started adding the function name to all of our functions (see the mWater function modification). I've been working my way through doing this across all functions ahead of putting them in the city's system to reduce potential for changes in function names, etc. if packages add/modify function names in the future!

-Katie