search

rossyndicate / poudre_sonde_network

MIT License
0 stars 7 forks source link

Ammending relevant sondes plotted #150

Closed juandlt-csu closed 1 month ago

juandlt-csu commented 2 months ago

There was an error in how I pulled in the relevant sonde data to be plotted based on the site_arg. These updates should plot only the relevant sonde data. Since these updates are almost identical across the three plotting functions this section may become a function in the future.

Please make sure that the plots are correct and these updates don't break your forks.

SamStruthers commented 1 month ago

Tested on my end:

I would not recommend merging this to main just yet

juandlt-csu commented 1 month ago

Tested on my end:

  • I tested about half the sites and they seem to plot as we would expect (upstream and downstream sites included)
  • Trib sites no longer show up on archery sites (virridy or CSU)
  • CSU archery site displays Virridy archery data (this is correct) but virridy archery does not display CSU archery on weekly scale. Interestingly, it does display on the daily plots....
  • River Bluffs sometimes shows archery CSU in 2023 but usually not. When Virridy sites come online in 2023, they all plot on the riverbluffs plots (Prospect, timberline, boxcreek, archery). When the other tribs (penn, lbea) come online in 2024, they also plot on the river bluffs plot (see image) river bluffs all sites

I would not recommend merging this to main just yet

I updated how we select the relevant sites based on the simpler solution based on the site look up that sam generated. test if this works out better.

SamStruthers commented 1 month ago

Just got around to actually testing this fully, seems to work on my end just fine! Thanks for the fix!! One thought for later versions/wide applicability, we can maybe format a CSV to look like the table below and then feed it into the network check/ these plotting versions

<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">

Site_arg | Upstream_site | Downstream_site | Additional_site1 | Additional_site_2 | Network_check -- | -- | -- | -- | -- | -- Tamasag | Pbd | Legacy | NA | NA | Y springcreek | NA | NA | Prospect | Prospect_virridy | N