search

rossyndicate / poudre_sonde_network

MIT License
0 stars 7 forks source link

Field notes integration #18

Closed kathryn-willi closed 1 year ago

kathryn-willi commented 1 year ago

I've started writing up code that uses the field sheet to identify times that the sensor was pulled from the field, and times when the sensor was pulled for calibration/cleaning/maintenance. @steeleb, I'm still not sure what the best SD approach is for finding wonky points. Quarterly didn't seem to be a high enough resolution, so I changed it to monthly. Still not great...

@juandlt-csu , please use this PR as an opportunity to review the entire workflow in the src/qaqc/01-organize-raw-data.Rmd. As it is, I am going through the automated QA-QC steps across a single site (Archery) and one parameter (temperature). Something I would also like you to double check for me is that all of our DT's are correct. The raw data files from the API pull are in UTC, and converted to MST. Meanwhile, the field notes and calibration notes are in MST. Could you verify that the dates listed in the temperature_archery object are in MST, and that the field notes and data are joined properly at lines ~278-281?

steeleb commented 1 year ago

And then to add some additional comments: I think that part of the flagging issue is that the flag ends up being centered, or on the left or right of problematic data, so it doesn't look like it's catching all that it should. I think that if we think about how each of these flags are working, we can define rules about how to add neighboring flags.