search

rossyndicate / poudre_sonde_network

MIT License
0 stars 7 forks source link

Lines of code 278-283 are hard to understand #22

Closed kathryn-willi closed 1 year ago

kathryn-willi commented 1 year ago 
          chore/nitpick: these lines of code (278-283) are really hard to follow and I'll be 100% honest that I have no idea what is happening here. Probably a me problem and likely could figure it out if I was running the code, but just reading/reviewing it would be helpful to have a comment before this so that the function is explained.

_Originally posted by @steeleb in https://github.com/rossyndicate/poudre_sonde_network/pull/18#discussion_r1294888110_

kathryn-willi commented 1 year ago

These lines of code are identifying when the sonde was removed from the site, for whatever reason (end of season, broken, etc.). For these times when we know that the sonde has no real data, any value that exists should be identified. So, this code creates a new column in the data set that flags any time the sonde was no longer collecting real data.