search

rossyndicate / poudre_sonde_network

MIT License
0 stars 8 forks source link

Partial solution to issue #22 #28

Closed juandlt-csu closed 1 year ago

juandlt-csu commented 1 year ago

This PR replaces the setnafill() method that was used to fill in NAs in the where column of field_notes with fill() from dplyr from issue 22.

The exact location where setnafill() was used from the original issue 22 has not been replaced yet. Instead, this step has been added onto the Load field notes step, where the field notes data has been padded and rearranged so that this new field_notes df can be joined onto all_data earlier in the data pipeline.

Note: both this and the previous method that was used are only accurate if the original field notes excel sheet is accurate. That should be checked to make sure that the sonde_pulled and sonde_deployed columns are accurate. For this reason I have decided to omit the option .direction = "downup" from fill(), for now.

This is progress on #22.

kathryn-willi commented 1 year ago

I think the only direction for the fill() function should be "down", as we only want to fill in missing values in the top-> down direction.