search

rossyndicate / poudre_sonde_network

MIT License
0 stars 8 forks source link

Added timelapse/wq code #4

Closed kathryn-willi closed 1 year ago

kathryn-willi commented 1 year ago

I added code to overlay water quality data with time lapse footage, and tidied up the code that QA/QC's the raw data. Developed functions to pull in outside data (e.g., FC storm data, LC diversion data).

steeleb commented 1 year ago

Lots of progress here! Well done. I made some comments in the scratch code (mostly to help with DT and functions), mostly because I didn't know where to start or where to focus. Looking further in your commit history, I probably could have workd from the most recent backwards. Sorry if some of the comments are unuseful.

Make sure in your PRs you name a focus area and what you want your reviewer to look at. In general, this is a TON of code and honestly, too much to review in one sitting without direction. Try to make PRs more frequently so your iCP only has to review ~ 500 lines of code. That's a SINGLE file in this PR. :). B