search

rossyndicate / poudre_sonde_network

MIT License
0 stars 7 forks source link

added ability to pass or fail an entire day's worth of data in remove… #57

Closed juandlt-csu closed 11 months ago

juandlt-csu commented 11 months ago

This PR just adds the ability to pass or fail an entire day's verification column within remove_flag_method.R. Also simplifies some of the code that was in the function.

juandlt-csu commented 11 months ago

Something to fix: As it it datapoints that are NA automatically fail. If a user approves an entire day, then NA data points that had previously failed will be converted to passes, which is wrong. This is incorrect and should be fixed.

kathryn-willi commented 11 months ago

Good catch, Juan. I also think that we will need to split up flags related to the sensor giving out bad data, and flags related to data not being collected. (Will discuss this/formalize in GitHub Issues tomorrow during our meeting)