search

rossyndicate / poudre_sonde_network

MIT License
0 stars 7 forks source link

Opening up a PR to merge Juan/PSN/targets to ross/PSN/main #93

Closed juandlt-csu closed 9 months ago

juandlt-csu commented 9 months ago

This PR is progress on #73 and updates the flag report analysis.

  1. Updating .gitignore so that it ignores the _targets/ folder (I talked to MB about this)
  2. _targets:
    1. I commented out the appending API data target step because I don’t want it to run yet.
    2. append_historical_api_data.R (special attention to logic here would be appreciated)
      1. This function combines the incoming API data and the historical API data and then deletes the files that are inside of the incoming_api_data folder.
  3. Flag report analysis:
    1. I will replace explore_and_fix_fxns/plotting_fxns/percent_flagged.R with flag_report_analysis2.
    2. This revamped function now has
      1. Updated san_na_flag list that is consistent with how we updated the large anomaly flag
      2. A structure that I believe is easier to follow along with more descriptive information on the steps in the function.
      3. This might need to be updated due to the updated slope flag
  4. Updated .Rmd that we were using to be less cluttered
  5. Added add_spec_flag() to make_threshold_table()