Work:
Creating WQ event figures for funder report in scratch reporting. Nothing affecting other workflows.
I think I fixed the small bug that was causing field notes to all be in UTC rather than MST with three fixes:
Looked like there was a small error in paste in the old field notes that was not actually creating MST DTs ( clean_field_notes)
Since this was applied to old field notes, it seems to have make the last_site_visit column in the historical data to be in UTC so when new data was joined, it made any new site visits UTC and then tried to join with the wrong DT_round. Essentially, I added a force_tz to the two points where historical data is joined with new data (append_to_historical_flagged_data and combine_hist_inc_data)
Review req:
no review on code for figures. just review on the figures themselves/narratives in the funder report
Test pipeline with tz fixes. Site visits in flagged data should align with DTs in field_notes
Work: Creating WQ event figures for funder report in scratch reporting. Nothing affecting other workflows.
I think I fixed the small bug that was causing field notes to all be in UTC rather than MST with three fixes:
clean_field_notes)last_site_visitcolumn in the historical data to be in UTC so when new data was joined, it made any new site visits UTC and then tried to join with the wrong DT_round. Essentially, I added a force_tz to the two points where historical data is joined with new data (append_to_historical_flagged_dataandcombine_hist_inc_data)Review req: