rossyndicate / poudre_sonde_network

MIT License
0 stars 7 forks source link

Fixing small bug in mWater api pull #96

Closed SamStruthers closed 7 months ago

SamStruthers commented 8 months ago

mWater decided to change the allowed forms of datetime which broke our parsing of the datetime columns (start_dt, end_dt and malfunction_end_dt). Work:

Review Req: Make sure the field notes seem to get pulled in correctly on your side and thoughts on whether we should move to using parse_datetime to give multiple formats in the event that this type of change occurs again

SamStruthers commented 8 months ago

@juandlt-csu I added the datetime parsing if you want to test using that instead of the changes I made before

SamStruthers commented 7 months ago

Neglected to merge to main before adding realistic range commits. @kathryn-willi check out the last couple commits for my recent changes. Work:

kathryn-willi commented 7 months ago

Going to merge and start incorporating your new flag as well as a few others. Please stay tuned for another PR from me sometime next week! :)